-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix subtly broken copy-on-write of ColumnLowCardinality dictionary #51064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll1
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Jun 16, 2023
This is an automated comment for commit 11b6dd0 with description of existing statuses. It's updated for the latest CI running
|
…py-on-write for the dictionary
al13n321
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Jun 16, 2023
evillique
approved these changes
Jun 16, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Jun 16, 2023
…Cardinality dictionary
robot-clickhouse
added a commit
that referenced
this pull request
Jun 16, 2023
…Cardinality dictionary
robot-clickhouse
added a commit
that referenced
this pull request
Jun 16, 2023
…Cardinality dictionary
robot-clickhouse
added a commit
that referenced
this pull request
Jun 16, 2023
…Cardinality dictionary
robot-ch-test-poll3
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Jun 16, 2023
alexey-milovidov
added a commit
that referenced
this pull request
Jun 16, 2023
Backport #51064 to 23.5: Fix subtly broken copy-on-write of ColumnLowCardinality dictionary
alexey-milovidov
added a commit
that referenced
this pull request
Jun 16, 2023
Backport #51064 to 23.3: Fix subtly broken copy-on-write of ColumnLowCardinality dictionary
alexey-milovidov
added a commit
that referenced
this pull request
Jun 16, 2023
Backport #51064 to 22.8: Fix subtly broken copy-on-write of ColumnLowCardinality dictionary
alexey-milovidov
added a commit
that referenced
this pull request
Jun 16, 2023
Backport #51064 to 23.4: Fix subtly broken copy-on-write of ColumnLowCardinality dictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed occasional LOGICAL_ERROR when using
LowCardinality(String)
: "String offsets has data inconsistent with chars array".Fixes #50715 (In addition to LOGICAL_ERRORs there were TSAN errors when it's enabled.)
This line in
ColumnLowCardinality::forEachSubcolumn()
:was trying to pass a const reference to
dictionary.column_unique
tocallback
. But that's not what actually happened.getColumnUniquePtr()
had slightly different return type thancallback
's argument type (ColumnPtr vs WrappedPtr), so this actually created a temporary local WrappedPtr and used a const reference to that.That would be fine, if not for the fact that
callback
then const_casts the reference and assigns it. So it ended up assigning a temporary local variable instead of the fielddictionary.column_unique
. Oops.This PR is a minimal fix that's easy to backport. Then #51072 does a little refactoring to prevent this specific error in future.